Issue 2627009: Swap D-Bus and IBus initialization order to avoid race conditions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2627009: Swap D-Bus and IBus initialization order to avoid race conditions. (Closed)

Created:
10 years, 6 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-os-reviews_chromium.org, Zachary Kuznia

Base URL:
ssh://git@gitrw.chromium.org//cros.git

Visibility:
Public.

Description

Swap D-Bus and IBus initialization order to avoid race conditions. Initialize D-Bus connection first so that the destructor of the InputMethodStatusConnection class does not terminate the IBus connection between im-ibus.so and ibus-daemon. This change is not for a specific bug, but might be worth not to trigger subtle bugs in im-ibus, libibus, and libdbus. BUG=none TEST=manually

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -14 lines)			Patch
	M	chromeos_input_method.cc	View		2 chunks	+15 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages