include CHROMEOS files and defintions in TOOLKIT_VEIWS build....

include CHROMEOS files and defintions in TOOLKIT_VEIWS build.
 * changed gyp files so that all files compiled for chrome os will be also compiled when toolkit_views==1
 * changed to define OS_CHROMEOS when toolkit_views==1
 * changed TabOverbiewMessageListener to use BrowserView instead of BrowserWindowGtk when toolkit_views==1
  I left one for CHROME_NOTIFY_FLOATING_TAB_OVER_TOPLEVEL b/c i couldn't figure out how to get gdkwindow
  from xid. Looks like I need to register it somewhere

Note: Nicolas updated trybot and buildbot to include chromeos dependency, so this all should compile fine.

BUG=none
TEST=run views unit test and browser.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28764

[oshima, 2009-10-12 19:08:29]

1st step to migrate to views.
once all components are ported to views, toolkit_views will be merged to
chromeos (both gyp and macro)

[sky, 2009-10-12 19:32:54]

http://codereview.chromium.org/262027/diff/8023/9023
File chrome/browser/views/frame/browser_view.h (right):

http://codereview.chromium.org/262027/diff/8023/9023#newcode89
Line 89: #if defined(OS_CHROMEOS)
I wouldn't bother with the ifdef for this.

http://codereview.chromium.org/262027/diff/8023/9019
File chrome/browser/views/tabs/tab_overview_message_listener.h (right):

http://codereview.chromium.org/262027/diff/8023/9019#newcode35
Line 35: static BrowserView* GetBrowserViewForGdkWindow(GdkWindow* gdk_window);
I think you're going to have #if def this around TOOLKIT_VIEWS.

[oshima, 2009-10-12 19:53:56]

http://codereview.chromium.org/262027/diff/8023/9023
File chrome/browser/views/frame/browser_view.h (right):

http://codereview.chromium.org/262027/diff/8023/9023#newcode89
Line 89: #if defined(OS_CHROMEOS)
On 2009/10/12 19:32:54, sky wrote:
> I wouldn't bother with the ifdef for this.

ok. done.

http://codereview.chromium.org/262027/diff/8023/9019
File chrome/browser/views/tabs/tab_overview_message_listener.h (right):

http://codereview.chromium.org/262027/diff/8023/9019#newcode35
Line 35: static BrowserView* GetBrowserViewForGdkWindow(GdkWindow* gdk_window);
On 2009/10/12 19:32:54, sky wrote:
> I think you're going to have #if def this around TOOLKIT_VIEWS.

done. it's not strictly necessary as we're moving to use this in views anyway
tho (and compiles fine)

[sky, 2009-10-12 19:56:57]

LGTM