chrome/browser/extensions/extension_messages_unittest.cc - Issue 262016: Implement chrome.extension.connectExternal and fix various API inconsistencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_messages_unittest.cc

Issue 262016: Implement chrome.extension.connectExternal and fix various API inconsistencies. (Closed)

Patch Set: addressed comments Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_messages_unittest.cc

diff --git a/chrome/browser/extensions/extension_messages_unittest.cc b/chrome/browser/extensions/extension_messages_unittest.cc

index 824609720fc3a11e837bc07cce8267be39f52525..cdb78cc0fa8095d0d332b2f1aa27cb27aa2c1d6f 100644

--- a/chrome/browser/extensions/extension_messages_unittest.cc

+++ b/chrome/browser/extensions/extension_messages_unittest.cc

@@ -16,6 +16,7 @@ static void DispatchOnConnect(int source_port_id, const std::string& name,

args.Set(1, Value::CreateStringValue(name));

args.Set(2, Value::CreateStringValue(tab_json));

args.Set(3, Value::CreateStringValue("")); // extension ID is empty for tests

+ args.Set(4, Value::CreateStringValue("")); // extension ID is empty for tests

RendererExtensionBindings::Invoke(

ExtensionMessageService::kDispatchOnConnect, args, NULL);

}

@@ -41,8 +42,7 @@ TEST_F(RenderViewTest, ExtensionMessagesOpenChannel) {

render_thread_.sink().ClearMessages();

LoadHTML("<body></body>");

ExecuteJavaScript(

- "var e = new chrome.Extension('foobar');"

- "var port = e.connect({name:'testName'});"

+ "var port = chrome.extension.connect({name:'testName'});"

"port.onMessage.addListener(doOnMessage);"

"port.postMessage({message: 'content ready'});"

"function doOnMessage(msg, port) {"

@@ -57,7 +57,7 @@ TEST_F(RenderViewTest, ExtensionMessagesOpenChannel) {

void* iter = IPC::SyncMessage::GetDataIterator(open_channel_msg);

ViewHostMsg_OpenChannelToExtension::SendParam open_params;

ASSERT_TRUE(IPC::ReadParam(open_channel_msg, &iter, &open_params));

- EXPECT_EQ("testName", open_params.c);

+ EXPECT_EQ("testName", open_params.d);

const IPC::Message* post_msg =

render_thread_.sink().GetUniqueMessageMatching(