Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2371)

Unified Diff: chrome/browser/extensions/extension_message_service.h

Issue 262016: Implement chrome.extension.connectExternal and fix various API inconsistencies. (Closed)
Patch Set: addressed comments Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_message_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_message_service.h
diff --git a/chrome/browser/extensions/extension_message_service.h b/chrome/browser/extensions/extension_message_service.h
index 10c579f46d3582f08ef96168de9afe7268f09c09..eb66bb6d133b26999dee4a4e545d3e571a2d651b 100644
--- a/chrome/browser/extensions/extension_message_service.h
+++ b/chrome/browser/extensions/extension_message_service.h
@@ -114,7 +114,9 @@ class ExtensionMessageService
// an optional identifier for use by extension developers.
// This runs on the IO thread so that it can be used in a synchronous IPC
// message.
- int OpenChannelToExtension(int routing_id, const std::string& extension_id,
+ int OpenChannelToExtension(int routing_id,
+ const std::string& source_extension_id,
+ const std::string& target_extension_id,
const std::string& channel_name,
ResourceMessageFilter* source);
@@ -146,7 +148,9 @@ class ExtensionMessageService
// opened.
void OpenChannelToExtensionOnUIThread(
int source_process_id, int source_routing_id, int receiver_port_id,
- const std::string& extension_id, const std::string& channel_name);
+ const std::string& source_extension_id,
+ const std::string& target_extension_id,
+ const std::string& channel_name);
void OpenChannelToTabOnUIThread(
int source_process_id, int source_routing_id, int receiver_port_id,
@@ -157,7 +161,9 @@ class ExtensionMessageService
bool OpenChannelOnUIThreadImpl(
IPC::Message::Sender* source, TabContents* source_contents,
const MessagePort& receiver, int receiver_port_id,
- const std::string& extension_id, const std::string& channel_name);
+ const std::string& source_extension_id,
+ const std::string& target_extension_id,
+ const std::string& channel_name);
// NotificationObserver interface.
void Observe(NotificationType type,
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_message_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698