Implement chrome.extension.connectExternal and fix various API inconsistencies.

chrome/renderer/resources/extension_process_bindings.js

 // Copyright (c) 2009 The chrome Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// -----------------------------------------------------------------------------
-// NOTE: If you change this file you need to touch renderer_resources.grd to
-// have your change take effect.
-// -----------------------------------------------------------------------------
-
 // This script contains privileged chrome extension related javascript APIs.
 // It is loaded by pages whose URL has the chrome-extension protocol.
 
 var chrome = chrome || {};
 (function() {
   native function GetExtensionAPIDefinition();
   native function StartRequest();
   native function GetCurrentPageActions(extensionId);
   native function GetExtensionViews();
   native function GetChromeHidden();
@@ skipping 194 matching lines @@
 
   function setupToolstripEvents(renderViewId) {
     chrome.toolstrip = chrome.toolstrip || {};
     chrome.toolstrip.onExpanded =
         new chrome.Event("toolstrip.onExpanded." + renderViewId);
     chrome.toolstrip.onCollapsed =
         new chrome.Event("toolstrip.onCollapsed." + renderViewId);
   }
 
   chromeHidden.onLoad.addListener(function (extensionId) {
-    chrome.extension = new chrome.Extension(extensionId);
-
-    // TODO(mpcomplete): chrome.self is deprecated.  Remove it at 1.0.
-    // http://code.google.com/p/chromium/issues/detail?id=16356
-    chrome.self = chrome.extension;
+    chrome.initExtension(extensionId);
 
     // |apiFunctions| is a hash of name -> object that stores the
     // name & definition of the apiFunction. Custom handling of api functions
     // is implemented by adding a "handleRequest" function to the object.
     var apiFunctions = {};
 
     // Read api definitions and setup api functions in the chrome namespace.
     // TODO(rafaelw): Consider defining a json schema for an api definition
     //   and validating either here, in a unit_test or both.
     // TODO(rafaelw): Handle synchronous functions.
@@ skipping 51 matching lines @@
         });
       }
     });
 
     apiFunctions["tabs.connect"].handleRequest = function(tabId, connectInfo) {
       var name = "";
       if (connectInfo) {
         name = connectInfo.name || name;
       }
       var portId = OpenChannelToTab(
-          tabId, chrome.extension.id_, name);
+          tabId, chromeHidden.extensionId, name);
       return chromeHidden.Port.createPort(portId, name);
     }
 
     apiFunctions["extension.getViews"].handleRequest = function() {
       return GetExtensionViews(-1, "ALL");
     }
 
     apiFunctions["extension.getBackgroundPage"].handleRequest = function() {
       return GetExtensionViews(-1, "BACKGROUND")[0] || null;
     }
@@ skipping 37 matching lines @@
         sendCustomRequest(SetBrowserActionIcon, "browserAction.setIcon",
                           idOrImageData, this.definition.parameters);
       }
     }
 
     setupPageActionEvents(extensionId);
     setupBrowserActionEvent(extensionId);
     setupToolstripEvents(GetRenderViewId());
   });
 })();