Implement chrome.extension.connectExternal and fix various API inconsistencies.

chrome/renderer/extensions/renderer_extension_bindings.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/renderer_extension_bindings.h"
 
 #include "app/resource_bundle.h"
 #include "base/basictypes.h"
 #include "base/values.h"
 #include "chrome/common/render_messages.h"
@@ skipping 59 matching lines @@
 
   // Creates a new messaging channel to the given extension.
   static v8::Handle<v8::Value> OpenChannelToExtension(
       const v8::Arguments& args) {
     // Get the current RenderView so that we can send a routed IPC message from
     // the correct source.
     RenderView* renderview = bindings_utils::GetRenderViewForCurrentContext();
     if (!renderview)
       return v8::Undefined();
 
-    if (args.Length() >= 2 && args[0]->IsString() && args[1]->IsString()) {
-      std::string id = *v8::String::Utf8Value(args[0]->ToString());
-      std::string channel_name = *v8::String::Utf8Value(args[1]->ToString());
+    if (args.Length() >= 3 && args[0]->IsString() && args[1]->IsString() &&
+        args[2]->IsString()) {
+      std::string source_id = *v8::String::Utf8Value(args[0]->ToString());
+      std::string target_id = *v8::String::Utf8Value(args[1]->ToString());
+      std::string channel_name = *v8::String::Utf8Value(args[2]->ToString());
       int port_id = -1;
       renderview->Send(new ViewHostMsg_OpenChannelToExtension(
-          renderview->routing_id(), id, channel_name, &port_id));
+          renderview->routing_id(), source_id, target_id,
+          channel_name, &port_id));
       return v8::Integer::New(port_id);
     }
     return v8::Undefined();
   }
 
   // Sends a message along the given channel.
   static v8::Handle<v8::Value> PostMessage(const v8::Arguments& args) {
     RenderView* renderview = bindings_utils::GetRenderViewForCurrentContext();
     if (!renderview)
       return v8::Undefined();
@@ skipping 101 matching lines @@
   return extension;
 }
 
 void RendererExtensionBindings::Invoke(const std::string& function_name,
                                        const ListValue& args,
                                        RenderView* renderview) {
   v8::HandleScope handle_scope;
   std::vector< v8::Handle<v8::Value> > argv = ListValueToV8(args);
   EventBindings::CallFunction(function_name, argv.size(), &argv[0], renderview);
 }