Issue 2620004: Patch opencryptoki not to call openlog("openCryptokiModule")

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2620004: Patch opencryptoki not to call openlog("openCryptokiModule") (Closed)

Created:
10 years, 6 months ago by Nathan Williams

Modified:
9 years, 6 months ago

Reviewers:
Chris Masone, Sam Leffler

CC:
chromium-os-reviews_chromium.org, Jason Glasgow

Base URL:
ssh://git@chromiumos-git/chromiumos-overlay.git

Visibility:
Public.

Description

Patch opencryptoki not to call openlog("openCryptokiModule") since this affects the syslog messages of the calling daemons as well, and makes it difficult to search for and distinguish them in log files.

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, --1 lines)			Patch
A	dev-libs/opencryptoki/files/opencryptoki-2.2.8-remove_openlog.patch	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	dev-libs/opencryptoki/opencryptoki-2.2.8.ebuild	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	dev-libs/opencryptoki/opencryptoki-2.2.8-r5.ebuild	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nathan Williams

I got tired of wpa_supplicant and entd ending up with the same syslog label after ...

10 years, 6 months ago (2010-06-04 21:15:37 UTC) #1

Sam Leffler

I don't see how this could happen based on your changes? wpa_supplicant does: wpa_debug.c: openlog("wpa_supplicant", ...

10 years, 6 months ago (2010-06-04 21:28:16 UTC) #2

Never mind; I understand now.

LGTM

Expand Messages | Collapse Messages