Issue 26179009: [telemetry] Restore --reset-html-results option and rename to --reset-results

Issue 26179009: [telemetry] Restore --reset-html-results option and rename to --reset-results (Closed)

Created:
7 years, 2 months ago by shatch

Modified:
7 years, 2 months ago

Reviewers:
dtu, tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[telemetry] Restore --reset-html-results option and rename to --reset-results Would like to use this on the perf try bot to clean out the html results before running the comparison tests. The plan is ultimately to get the perf try bot to upload the results to cloud storage. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229206

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changes from review. #

Patch Set 3 : Fix PageRunnerTests. #

Total comments: 2

Patch Set 4 : Fixed message in results-template.html. #

Patch Set 5 : Overwrote pagerunnertest fix with last patch. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -7 lines)			Patch
M	tools/telemetry/support/html_output/results-template.html	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/page/html_page_measurement_results.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/page/html_page_measurement_results_unittest.py	View		3 chunks	+57 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page_runner_unittest.py	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/results_options.py	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 19 (0 generated)

Expand Messages | Collapse Messages

tonyg

lgtm https://codereview.chromium.org/26179009/diff/1/tools/telemetry/telemetry/page/results_options.py File tools/telemetry/telemetry/page/results_options.py (right): https://codereview.chromium.org/26179009/diff/1/tools/telemetry/telemetry/page/results_options.py#newcode37 tools/telemetry/telemetry/page/results_options.py:37: help='Delete all stored runs in HTML output') In ...

7 years, 2 months ago (2013-10-15 20:41:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/26179009/6001

7 years, 2 months ago (2013-10-15 21:01:14 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=177517

7 years, 2 months ago (2013-10-15 22:18:16 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/26179009/6001

7 years, 2 months ago (2013-10-15 22:28:59 UTC) #5

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=177564

7 years, 2 months ago (2013-10-16 00:10:32 UTC) #6

tonyg

This trybot failure looks legit: http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/177564/steps/telemetry_unittests/logs/testDiscardFirstResult On Tue, Oct 15, 2013 at 5:10 PM, <commit-bot@chromium.org> ...

7 years, 2 months ago (2013-10-16 00:30:13 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/26179009/35001

7 years, 2 months ago (2013-10-16 17:59:31 UTC) #8

tonyg

https://codereview.chromium.org/26179009/diff/35001/tools/telemetry/support/html_output/results-template.html File tools/telemetry/support/html_output/results-template.html (right): https://codereview.chromium.org/26179009/diff/35001/tools/telemetry/support/html_output/results-template.html#newcode191 tools/telemetry/support/html_output/results-template.html:191: Run Telemetry with --reset-html-results to clear all runs Oops, ...

7 years, 2 months ago (2013-10-16 18:09:21 UTC) #9

shatch

7 years, 2 months ago (2013-10-16 18:13:25 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/26179009/48001

7 years, 2 months ago (2013-10-16 18:13:37 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/26179009/48001

7 years, 2 months ago (2013-10-16 20:40:39 UTC) #12

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/26179009/48001

7 years, 2 months ago (2013-10-16 21:23:02 UTC) #13

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/26179009/48001

7 years, 2 months ago (2013-10-17 01:32:45 UTC) #14

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 2 months ago (2013-10-17 02:46:59 UTC) #15

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/26179009/48001

7 years, 2 months ago (2013-10-17 03:02:41 UTC) #16

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 2 months ago (2013-10-17 04:07:51 UTC) #17

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/26179009/103001

7 years, 2 months ago (2013-10-17 16:11:21 UTC) #18

Message was sent while issue was closed.

Change committed as 229206

Expand Messages | Collapse Messages