Start migrating the disk cache to using FilePath.

Start migrating the disk cache to using FilePath.

This converts BackendImpl to using FilePath.

BUG=24444
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28711

[tony, 2009-10-09 22:15:19]

I think the trybot is full of lies and this should be fine on Windows.  Passes
all tests on linux/mac.

[Lei Zhang, 2009-10-09 22:28:51]

LGTM

http://codereview.chromium.org/261045/diff/3001/4001
File net/disk_cache/backend_impl.cc (right):

http://codereview.chromium.org/261045/diff/3001/4001#newcode71
Line 71: std::wstring tmp = StringPrintf(L"%ls%ls_%03d", L"old_", name.c_str(),
index);
If you use the std::string version of StringPrintf() here, you can probably get
rid of many more wstrings and To/FromWstringHacks.

http://codereview.chromium.org/261045/diff/3001/4004
File net/disk_cache/cache_util.h (right):

http://codereview.chromium.org/261045/diff/3001/4004#newcode23
Line 23: // Obsolete.
Can we mark them deprecated instead? Ditto on line 28 below.

[tony, 2009-10-09 22:48:07]

http://codereview.chromium.org/261045/diff/3001/4001
File net/disk_cache/backend_impl.cc (right):

http://codereview.chromium.org/261045/diff/3001/4001#newcode71
Line 71: std::wstring tmp = StringPrintf(L"%ls%ls_%03d", L"old_", name.c_str(),
index);
On 2009/10/09 22:28:52, Lei Zhang wrote:
> If you use the std::string version of StringPrintf() here, you can probably
get
> rid of many more wstrings and To/FromWstringHacks.

Done.

http://codereview.chromium.org/261045/diff/3001/4004
File net/disk_cache/cache_util.h (right):

http://codereview.chromium.org/261045/diff/3001/4004#newcode23
Line 23: // Obsolete.
On 2009/10/09 22:28:52, Lei Zhang wrote:
> Can we mark them deprecated instead? Ditto on line 28 below.

Done.

[Lei Zhang, 2009-10-09 22:52:10]

http://codereview.chromium.org/261045/diff/6001/2016
File net/disk_cache/backend_impl.cc (right):

http://codereview.chromium.org/261045/diff/6001/2016#newcode70
Line 70: std::string tmp = StringPrintf("%ls%ls_%03d", "old_", name.c_str(),
index);
Isn't %ls for wide string? %s%s%03d ?

[tony, 2009-10-09 22:55:15]

Yes, you're right.  Fixed.

[Lei Zhang, 2009-10-09 22:57:16]

LGTM

[rvargas (doing something else), 2009-10-10 00:40:13]

LGTM