Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 2609001: Add implementation for WebDevToolsAgentClient::debuggerScriptSource.... (Closed)

Created:
10 years, 6 months ago by podivilov
Modified:
9 years, 3 months ago
Reviewers:
pfeldman, yurys
CC:
chromium-reviews
Visibility:
Public.

Description

Add implementation for WebDevToolsAgentClient::debuggerScriptSource. To be able to stop on top-level breakpoints We need to enable javascript debugger before any scripts are executed. That's why DebuggerScript.js contents should be retrieved synchronously. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49045

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M chrome/renderer/devtools_agent.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/devtools_agent.cc View 1 3 chunks +8 lines, -2 lines 0 comments Download
M webkit/support/platform_support_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_devtools_agent.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_devtools_agent.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
podivilov
10 years, 6 months ago (2010-06-03 18:15:37 UTC) #1
yurys
I'm fine with the change, Pavel, do you think we should take this approach or ...
10 years, 6 months ago (2010-06-04 08:27:28 UTC) #2
podivilov
http://codereview.chromium.org/2609001/diff/1/7 File webkit/tools/test_shell/test_shell_win.cc (right): http://codereview.chromium.org/2609001/diff/1/7#newcode788 webkit/tools/test_shell/test_shell_win.cc:788: case IDR_DEVTOOLS_INJECT_DEBUG_JS: On 2010/06/04 08:27:28, Yury Semikhatsky wrote: > ...
10 years, 6 months ago (2010-06-04 08:31:40 UTC) #3
podivilov
10 years, 6 months ago (2010-06-04 14:05:43 UTC) #4
yurys
10 years, 6 months ago (2010-06-07 11:19:32 UTC) #5
LGTM, I'll land it.

Powered by Google App Engine
This is Rietveld 408576698