Issue 2608001: Change the test notification presenter to fire the display event asynchronous...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2608001: Change the test notification presenter to fire the display event asynchronous... (Closed)

Created:
10 years, 6 months ago by John Gregg

Modified:
9 years ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change the test notification presenter to fire the display event asynchronously, as this is what the spec calls for and enables more correct layout tests. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48893

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	webkit/tools/test_shell/notification_presenter.cc	View		3 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages