Issue 2606002: Ignore the AlternateLBA field in the GPT headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2606002: Ignore the AlternateLBA field in the GPT headers. (Closed)

Created:
10 years, 6 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, gauravsh

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

Ignore the AlternateLBA field in the GPT headers. We know where to look, and we'll look there regardless. We don't care where the header creator thinks it should be. Update tests to match. Oh, and don't assume that I mean "/dev/FOO" if I just say "FOO". That's really annoying.

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -27 lines)			Patch
M	src/platform/vboot_reference/tests/cgptlib_test.c	View	1 chunk	+4 lines, -4 lines	1 comment	Download
M	src/platform/vboot_reference/utility/cgpt/cgpt_options.c	View	1 chunk	+2 lines, -19 lines	0 comments	Download
M	src/platform/vboot_reference/utility/cgpt/cgpt_show.c	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/platform/vboot_reference/vboot_firmware/lib/cgptlib/cgptlib_internal.c	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

10 years, 6 months ago (2010-06-03 22:04:22 UTC) #2

LGTM with one tiny fix

http://codereview.chromium.org/2606002/diff/1/2
File src/platform/vboot_reference/tests/cgptlib_test.c (right):

http://codereview.chromium.org/2606002/diff/1/2#newcode457
src/platform/vboot_reference/tests/cgptlib_test.c:457: BuildTestGptData(gpt);
Add a comment that we're explicitly ignoring the alternate_lba field

Expand Messages | Collapse Messages