Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 2605007: Fix a regression on Windows introduced by r48650.... (Closed)

Created:
10 years, 6 months ago by wtc
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai, agl
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Fix a regression on Windows introduced by r48650. For some reason, passing NULL as the hCertStore argument to CertAddEncodedCertificateToStore causes CertGetCertificateChain to fail to build the certificate chain for some servers, even though the hCertStore member of the server certificate context should contain its CA certificates. So I reverted to passing our in-memory certificate store as the hCertStore argument to CertAddEncodedCertificateToStore. R=agl,mark BUG=45706 TEST=Visit https://moversguide.usps.com/ on Windows. Should not get the "certificate is not trusted" SSL error page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M net/socket/ssl_client_socket_nss.h View 3 chunks +9 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 3 chunks +25 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wtc
10 years, 6 months ago (2010-06-03 21:56:11 UTC) #1
Mark Mentovai
LGTM
10 years, 6 months ago (2010-06-03 21:58:21 UTC) #2
agl
10 years, 6 months ago (2010-06-03 22:00:50 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698