Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2601: Fixed build problem on mac, lint issues and a test failure on win32. (Closed)

Created:
12 years, 3 months ago by plesner
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fixed build problem on mac, lint issues and a test failure on win32. Committed: http://code.google.com/p/v8/source/detail?r=285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -13 lines) Patch
M src/platform-macos.cc View 4 chunks +32 lines, -7 lines 0 comments Download
M src/platform-win32.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/utils.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
plesner
12 years, 3 months ago (2008-09-11 15:01:05 UTC) #1
Mads Ager (chromium)
12 years, 3 months ago (2008-09-11 15:02:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698