Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 260014: Modify gcl lint to pull the IGNORE_PATH from codereview.settings instead of... (Closed)

Created:
11 years, 2 months ago by Dirk Pranke
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Set LINT_IGNORE_REGEX to not try to lint files using webkit coding standards (everything in webkit/api) See http://codereview.chromium.org/257054/show for the change to gcl that is also needed. R=maruel@chromium.org BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30501

Patch Set 1 #

Patch Set 2 : updated to use regexes #

Patch Set 3 : switch to using one regex instead of a list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M codereview.settings View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
11 years, 2 months ago (2009-10-05 22:19:37 UTC) #1
M-A Ruel
I'll wait for http://codereview.chromium.org/257054 to be done reviewing before accepting this one.
11 years, 2 months ago (2009-10-07 13:33:46 UTC) #2
Dirk Pranke
11 years, 1 month ago (2009-10-28 02:48:44 UTC) #3
Dirk Pranke
11 years, 1 month ago (2009-10-28 21:28:53 UTC) #4
M-A Ruel
11 years, 1 month ago (2009-10-29 01:30:34 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698