Chromium Code Reviews

Issue 260006: [chrome-reviews] Change flag "auto-spell-correct" to "advanced-spellchecker". I will be making... (Closed)

Created:
11 years, 2 months ago by sidchat (Google)
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Change flag "auto-spell-correct" to "experimental-spellchecker-features". I will be making a series of new features in spellchecking, and will keep all of them under this flag till they become mature enough for default use. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28055

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Stats (+16 lines, -9 lines)
M chrome/browser/gtk/options/languages_page_gtk.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +1 line, -1 line 0 comments
M chrome/browser/views/options/languages_page_view.cc View 3 chunks +3 lines, -3 lines 0 comments
M chrome/common/chrome_switches.h View 1 chunk +1 line, -1 line 0 comments
M chrome/common/chrome_switches.cc View 1 chunk +9 lines, -2 lines 0 comments
M chrome/renderer/render_view.cc View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 4 (0 generated)
sidchat (Google)
11 years, 2 months ago (2009-10-02 23:11:27 UTC) #1
Peter Kasting
http://codereview.chromium.org/260006/diff/1/2 File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/260006/diff/1/2#newcode469 Line 469: const wchar_t kAutoSpellCorrect[] = L"advanced-spellchecker"; Please change the ...
11 years, 2 months ago (2009-10-02 23:14:02 UTC) #2
sidchat (Google)
Right - I overlooked the flag variable name. Made changes - please have another look. ...
11 years, 2 months ago (2009-10-02 23:43:01 UTC) #3
Peter Kasting
11 years, 2 months ago (2009-10-02 23:49:23 UTC) #4 
LGTM with nits

http://codereview.chromium.org/260006/diff/6001/7001
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/260006/diff/6001/7001#newcode475
Line 475: const wchar_t kExperimentalSpellchecker[] =
Nit: Align the "=" with the ones above and below (file style).

http://codereview.chromium.org/260006/diff/6001/7005
File chrome/common/chrome_switches.h (right):

http://codereview.chromium.org/260006/diff/6001/7005#newcode181
Line 181: extern const wchar_t kExperimentalSpellchecker[];
Nit: Why not kExperimentalSpellcheckerFeatures?  Makes a lot more sense when
reading it...

Powered by Google App Engine