Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 260003: Move the clipboard stuff out of base and into app/clipboard. I renamed... (Closed)

Created:
11 years, 2 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, jam, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review), tim (not reviewing)
Visibility:
Public.

Description

Move the clipboard stuff out of base and into app/clipboard. I renamed clipboard_util to clipboard_util_win since it's Windows-only. This patch makes test_shell depend on app as well. There should be no logic change. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27937

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -2990 lines) Patch
M app/app.gyp View 2 chunks +10 lines, -0 lines 0 comments Download
A + app/clipboard/clipboard.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + app/clipboard/clipboard.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + app/clipboard/clipboard_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + app/clipboard/clipboard_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + app/clipboard/clipboard_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + app/clipboard/clipboard_util_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + app/clipboard/clipboard_util_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + app/clipboard/clipboard_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + app/clipboard/scoped_clipboard_writer.h View 2 chunks +5 lines, -4 lines 0 comments Download
A + app/clipboard/scoped_clipboard_writer.cc View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download
M app/os_exchange_data_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M app/os_exchange_data_win_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/base.gyp View 4 chunks +0 lines, -11 lines 0 comments Download
D base/clipboard.h View 1 chunk +0 lines, -259 lines 0 comments Download
D base/clipboard.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D base/clipboard_linux.cc View 1 chunk +0 lines, -410 lines 0 comments Download
D base/clipboard_mac.mm View 1 chunk +0 lines, -284 lines 0 comments Download
D base/clipboard_unittest.cc View 1 chunk +0 lines, -337 lines 0 comments Download
D base/clipboard_util.h View 1 chunk +0 lines, -65 lines 0 comments Download
D base/clipboard_util.cc View 1 chunk +0 lines, -502 lines 0 comments Download
D base/clipboard_win.cc View 1 chunk +0 lines, -686 lines 0 comments Download
D base/scoped_clipboard_writer.h View 1 chunk +0 lines, -84 lines 0 comments Download
D base/scoped_clipboard_writer.cc View 1 chunk +0 lines, -176 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_drag_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/net/browser_url_util.h View 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/net/browser_url_util.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/web_drop_target.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/chrome_views_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/render_messages.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_glue.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/testing_browser_process.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/net_util.h View 2 chunks +0 lines, -6 lines 0 comments Download
M net/base/net_util.cc View 4 chunks +2 lines, -20 lines 0 comments Download
M views/controls/message_box_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M views/controls/textfield/native_textfield_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/scoped_clipboard_writer_glue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/webclipboard_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webclipboard_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webdropdata_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webkit_glue.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/mock_webclipboard_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/simple_clipboard_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
11 years, 2 months ago (2009-10-02 17:57:38 UTC) #1
sky
11 years, 2 months ago (2009-10-02 18:03:38 UTC) #2
As long as this compiles, LGTM rubber stamp.

Powered by Google App Engine
This is Rietveld 408576698