Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 260002: Add a method to convert unsigned C integer into V8 Integer. (Closed)

Created:
11 years, 2 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add a method to convert unsigned C integer into V8 Integer. Committed: http://code.google.com/p/v8/source/detail?r=3013

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -0 lines) Patch
M include/v8.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M src/checks.h View 1 1 chunk +19 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
antonm
11 years, 2 months ago (2009-10-02 13:16:49 UTC) #1
Christian Plesner Hansen
Lgtm. http://codereview.chromium.org/260002/diff/1/3 File include/v8.h (right): http://codereview.chromium.org/260002/diff/1/3#newcode3023 Line 3023: Local<Integer> Integer::New(uint32_t value) { We should treat ...
11 years, 2 months ago (2009-10-02 13:22:06 UTC) #2
antonm
http://codereview.chromium.org/260002/diff/1/3 File include/v8.h (right): http://codereview.chromium.org/260002/diff/1/3#newcode3023 Line 3023: Local<Integer> Integer::New(uint32_t value) { On 2009/10/02 13:22:07, Christian ...
11 years, 2 months ago (2009-10-02 13:24:50 UTC) #3
Christian Plesner Hansen
11 years, 2 months ago (2009-10-02 13:26:21 UTC) #4
http://codereview.chromium.org/260002/diff/1/3
File include/v8.h (right):

http://codereview.chromium.org/260002/diff/1/3#newcode3023
Line 3023: Local<Integer> Integer::New(uint32_t value) {
That's fine by me.

Powered by Google App Engine
This is Rietveld 408576698