Significantly improve gclient_smoketest.py

Significantly improve gclient_smoketest.py.

Add a lot of checking for stdout and fix one mis-assumption.
Make the code much more compact.
Make the git_hashes 'revisions' 1-based for consistency.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48925

[M-A Ruel, 2010-06-03 21:13:11]

It was depressing work but I think it was worth.

[Mandeep Singh Baines, 2010-06-03 22:51:07]

Nice work!

Some nits.

http://codereview.chromium.org/2594001/diff/2001/3001
File tests/fake_repos.py (right):

http://codereview.chromium.org/2594001/diff/2001/3001#newcode159
tests/fake_repos.py:159: for item in scm.SVN.CaptureStatus(repo):
might be cleaner if you used a tuple here:

status, item

http://codereview.chromium.org/2594001/diff/2001/3001#newcode469
tests/fake_repos.py:469: 'hash': self.git_hashes['repo_2'][1][0][:7]
Use a temporary variable instead of using such a long expansion.

Its difficult to understand what git_hashes['repo_2'][1][0][:7] is?

[M-A Ruel, 2010-06-04 01:29:39]

updated

[Nasser Grainawi, 2010-06-04 14:39:47]

lgtm, 20 tests ran successfully w/ git version 1.7.1

[Mandeep Singh Baines, 2010-06-04 14:41:37]

LGTM