Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 259065: Add an BubbleBorder to BrowserAction popups and fix positioning of the (Closed)

Created:
11 years, 2 months ago by Erik does not do reviews
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add an BubbleBorder to BrowserAction popups and fix positioning of the popup. BUG=23833, 23835 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28187

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -32 lines) Patch
M chrome/browser/views/browser_actions_container.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/browser_bubble.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/views/browser_bubble_win.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/views/bubble_border.h View 1 3 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/views/bubble_border.cc View 1 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/browser/views/extensions/extension_popup.h View 1 4 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/views/extensions/extension_popup.cc View 1 1 chunk +44 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/samples/set_page_color/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/samples/set_page_color/popup.html View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik does not do reviews
11 years, 2 months ago (2009-10-06 23:11:35 UTC) #1
Aaron Boodman
11 years, 2 months ago (2009-10-06 23:18:36 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698