Issue 259058: Added command line flag --sync_with_push (default: true) to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 259058: Added command line flag --sync_with_push (default: true) to... (Closed)

Created:
11 years, 2 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Added command line flag --sync_with_push (default: true) to emit 'push' instead of 'sub esp, xxx' followed by 'mov' instructions Reduces generated code size by 10-15% on several benchmarks. Done on ia32 and x64 (no sync operation in the virtual frame on ARM architecture)

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -16 lines)			Patch
	M	src/ia32/virtual-frame-ia32.cc	View	1	1 chunk	+9 lines, -8 lines	0 comments	Download
	M	src/x64/virtual-frame-x64.cc	View	1	1 chunk	+9 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fschneider

Uploaded new patchset. As Kevin suggested I dropped the command line flag and removed the ...

11 years, 2 months ago (2009-10-07 12:06:59 UTC) #2

LGTM.

Expand Messages | Collapse Messages