Issue 259052: Reverting the NativeViewHostWin focus refactoring....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 259052: Reverting the NativeViewHostWin focus refactoring.... (Closed)

Created:
11 years, 2 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, pam+watch_chromium.org, Paweł Hajdan Jr., tim (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Reverting the NativeViewHostWin focus refactoring. It seems the added subclassing is causing crashers in the field. BUG=23861 TEST=None TBR=beng Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28061

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -268 lines)			Patch
M	base/win_util.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_gtk.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_mac.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_win.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_win.cc	View	2 chunks	+9 lines, -4 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.cc	View	3 chunks	+11 lines, -5 lines	0 comments	Download
M	views/controls/native/native_view_host.h	View	3 chunks	+8 lines, -27 lines	0 comments	Download
M	views/controls/native/native_view_host.cc	View	6 chunks	+6 lines, -34 lines	0 comments	Download
M	views/controls/native/native_view_host_gtk.h	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	views/controls/native/native_view_host_gtk.cc	View	4 chunks	+20 lines, -7 lines	0 comments	Download
M	views/controls/native/native_view_host_win.h	View	3 chunks	+4 lines, -14 lines	0 comments	Download
M	views/controls/native/native_view_host_win.cc	View	4 chunks	+3 lines, -43 lines	0 comments	Download
MM	views/controls/native/native_view_host_wrapper.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	views/controls/native_control.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
MM	views/controls/native_control_gtk.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	views/controls/native_control_gtk.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	views/controls/native_control_win.cc	View	4 chunks	+20 lines, -11 lines	0 comments	Download
M	views/focus/focus_manager_unittest.cc	View	3 chunks	+1 line, -103 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages