Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1338)

Unified Diff: chrome/browser/gtk/keyword_editor_view.cc

Issue 259029: Remove a NOTREACHED from the keyword editor dialog. To hit, (Closed)
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/keyword_editor_view.cc
diff --git a/chrome/browser/gtk/keyword_editor_view.cc b/chrome/browser/gtk/keyword_editor_view.cc
index 1409dc15e2c5eafee058ad4c4784cfd975a80577..5021fc1ac706db2fe86432bc59a6316f8304c007 100644
--- a/chrome/browser/gtk/keyword_editor_view.cc
+++ b/chrome/browser/gtk/keyword_editor_view.cc
@@ -447,10 +447,9 @@ void KeywordEditorView::OnAddButtonClicked(GtkButton* button,
void KeywordEditorView::OnEditButtonClicked(GtkButton* button,
KeywordEditorView* editor) {
int model_row = editor->GetSelectedModelRow();
- if (model_row == -1) {
- NOTREACHED();
+ if (model_row == -1)
return;
- }
+
new EditSearchEngineDialog(
GTK_WINDOW(gtk_widget_get_toplevel(editor->dialog_)),
editor->controller_->GetTemplateURL(model_row),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698