Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6541)

Unified Diff: chrome_frame/chrome_tab.cc

Issue 259025: Add the chromeframe tag to the user agent header at runtime instead of static... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/chrome_frame.gyp ('k') | chrome_frame/html_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/chrome_tab.cc
===================================================================
--- chrome_frame/chrome_tab.cc (revision 29337)
+++ chrome_frame/chrome_tab.cc (working copy)
@@ -3,6 +3,12 @@
// found in the LICENSE file.
// chrome_tab.cc : Implementation of DLL Exports.
+
+// Include without path to make GYP build see it.
+#include "chrome_tab.h" // NOLINT
+
+#include <atlsecurity.h>
+
#include "base/at_exit.h"
#include "base/command_line.h"
#include "base/file_util.h"
@@ -23,10 +29,6 @@
#include "chrome_frame/resource.h"
#include "chrome_frame/utils.h"
-// Include without path to make GYP build see it.
-#include "chrome_tab.h" // NOLINT
-#include <atlsecurity.h>
-
static const wchar_t kBhoRegistryPath[] =
L"Software\\Microsoft\\Windows\\CurrentVersion\\Explorer"
L"\\Browser Helper Objects";
@@ -148,6 +150,7 @@
const wchar_t kClockUserAgent[] = L"chromeframe";
// To delete the clock user agent, set value to NULL.
+// TODO(tommi): Remove this method when it's no longer used.
HRESULT SetClockUserAgent(const wchar_t* value) {
HRESULT hr;
RegKey ua_key;
@@ -214,12 +217,14 @@
ie_bho_key.WriteValue(kBhoNoLoadExplorerValue, 1);
DLOG(INFO) << "Registered ChromeTab BHO";
- SetClockUserAgent(L"1");
+ // We now add the chromeframe user agent at runtime.
+ // SetClockUserAgent(L"1");
RefreshElevationPolicy();
return S_OK;
}
HRESULT UnregisterChromeTabBHO() {
+ // TODO(tommi): remove this in future versions.
SetClockUserAgent(NULL);
RegKey ie_bho_key;
« no previous file with comments | « chrome_frame/chrome_frame.gyp ('k') | chrome_frame/html_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698