Extracting the interactive ui tests to their own GYP file....

Extracting the interactive ui tests to their own GYP file.

BUG=None
TEST=The interactive tests should still build and run on Windows and Linux

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28404

[sgk, 2009-10-05 22:27:47]

http://codereview.chromium.org/259018/diff/2001/2003
File chrome/test/interactive_ui/interactive_ui_test.gyp (right):

http://codereview.chromium.org/259018/diff/2001/2003#newcode64
Line 64: }],  # OS=="linux"
Thanks for adding the comment, helps readability.

http://codereview.chromium.org/259018/diff/2001/2003#newcode79
Line 79: 'browser/autocomplete/autocomplete_edit_view_browsertest.cc',
Looks like the prepended '../../' prepended is missing from this one.

http://codereview.chromium.org/259018/diff/2001/2003#newcode172
Line 172: '../../browser/autocomplete/autocomplete_edit_view_browsertest.cc',
The cut-and-paste duplication of the file lists here is a potential source of
trouble.  What's the intent?  At a minimum, these should really be set in a
'variables' section at the top of the .gyp file and interpolated into the second
targets.

[jcampan, 2009-10-05 22:53:29]

http://codereview.chromium.org/259018/diff/2001/2003
File chrome/test/interactive_ui/interactive_ui_test.gyp (right):

http://codereview.chromium.org/259018/diff/2001/2003#newcode79
Line 79: 'browser/autocomplete/autocomplete_edit_view_browsertest.cc',
On 2009/10/05 22:27:47, sgk wrote:
> Looks like the prepended '../../' prepended is missing from this one.

Good catch, added.

http://codereview.chromium.org/259018/diff/2001/2003#newcode172
Line 172: '../../browser/autocomplete/autocomplete_edit_view_browsertest.cc',
On 2009/10/05 22:27:47, sgk wrote:
> The cut-and-paste duplication of the file lists here is a potential source of
> trouble.  What's the intent?  At a minimum, these should really be set in a
> 'variables' section at the top of the .gyp file and interpolated into the
second
> targets.

Actually it is not used right now, so I removed that target.

[sgk, 2009-10-05 23:00:29]

lgtm