src/arm/codegen-arm.cc - Issue 259013: Align the stack correctly on ARM on calls to fp operation helpers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/codegen-arm.cc

Issue 259013: Align the stack correctly on ARM on calls to fp operation helpers. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/codegen-arm.cc

===================================================================

--- src/arm/codegen-arm.cc (revision 3007)

+++ src/arm/codegen-arm.cc (working copy)

@@ -5061,11 +5061,14 @@

// r5: Address of heap number for result.

__ push(lr); // For later.

__ push(r5); // Address of heap number that is answer.

+ __ AlignStack(0);

// Call C routine that may not cause GC or other trouble.

__ mov(r5, Operand(ExternalReference::double_fp_operation(operation)));

__ Call(r5);

+ __ pop(r4); // Address of heap number.

+ __ cmp(r4, Operand(Smi::FromInt(0)));

+ __ pop(r4, eq); // Conditional pop instruction to get rid of alignment push.

// Store answer in the overwritable heap number.

- __ pop(r4);

#if !defined(USE_ARM_EABI)

// Double returned in fp coprocessor register 0 and 1, encoded as register

// cr8. Offsets must be divisible by 4 for coprocessor so we need to

« no previous file with comments | « src/arm/assembler-arm.h ('k') | src/arm/macro-assembler-arm.h » ('j') | no next file with comments »