Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 259004: First cut at badge implementation. Right now it just uses static (Closed)

Created:
11 years, 2 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

First cut at badge implementation. Right now it just uses static data. A subsequent change will hook it up to the extension APIs. See http://dl.getdropbox.com/u/124107/badges.png for a picture of what this looks like. BUG=23268 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27761

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -4 lines) Patch
M app/resources/app_resources.grd View 1 chunk +5 lines, -0 lines 0 comments Download
A app/resources/browser_action_badge_center.png View Binary file 0 comments Download
A app/resources/browser_action_badge_left.png View Binary file 0 comments Download
A app/resources/browser_action_badge_right.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/browser_actions_container.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/views/browser_actions_container.cc View 1 5 chunks +114 lines, -2 lines 1 comment Download
M chrome/browser/views/toolbar_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Aaron Boodman
11 years, 2 months ago (2009-10-01 19:40:29 UTC) #1
Erik does not do reviews
LGTM http://codereview.chromium.org/259004/diff/3001/4006 File chrome/browser/views/browser_actions_container.cc (right): http://codereview.chromium.org/259004/diff/3001/4006#newcode286 Line 286: text_paint.setTextAlign(SkPaint::kLeft_Align); Don't we want to be centered? ...
11 years, 2 months ago (2009-10-01 20:21:04 UTC) #2
Aaron Boodman
On Thu, Oct 1, 2009 at 1:21 PM, <erikkay@chromium.org> wrote: > http://codereview.chromium.org/259004/diff/3001/4006 > File chrome/browser/views/browser_actions_container.cc ...
11 years, 2 months ago (2009-10-01 20:30:40 UTC) #3
Erik does not do reviews
11 years, 2 months ago (2009-10-01 20:36:11 UTC) #4
I see it now.  Thanks.

Powered by Google App Engine
This is Rietveld 408576698