Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2586003: Explicitly list dependency files instead of searching for them. (Closed)

Created:
10 years, 6 months ago by Bill Richardson
Modified:
9 years, 6 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, gauravsh
Base URL:
ssh://git@chromiumos-git/chromeos
Visibility:
Public.

Description

Explicitly list dependency files instead of searching for them.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M src/platform/vboot_reference/vboot_firmware/Makefile View 1 chunk +25 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Richardson
10 years, 6 months ago (2010-06-03 18:20:13 UTC) #1
Randall Spangler
LGTM What about making the stubs their own library, since those are normally replaced by ...
10 years, 6 months ago (2010-06-03 19:20:14 UTC) #2
Bill Richardson
10 years, 6 months ago (2010-06-03 19:46:07 UTC) #3
On 2010/06/03 19:20:14, Randall Spangler wrote:
> LGTM
> 
> What about making the stubs their own library, since those are normally
replaced
> by full implementations in real usage?

In real usage none of these would be a library - they'd just be compiled in as
part of the BIOS source.

Powered by Google App Engine
This is Rietveld 408576698