A quick fix for Issue 23745....

webkit/tools/test_shell/event_sending_controller.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains the definition for EventSendingController.
 //
 // Some notes about drag and drop handling:
 // Windows drag and drop goes through a system call to DoDragDrop.  At that
 // point, program control is given to Windows which then periodically makes
 // callbacks into the webview.  This won't work for layout tests, so instead,
@@ skipping 129 matching lines @@
 }
 
 void ApplyKeyModifier(const std::wstring& arg, WebKeyboardEvent* event) {
   const wchar_t* arg_string = arg.c_str();
   if (!wcscmp(arg_string, L"ctrlKey")) {
     event->modifiers |= WebInputEvent::ControlKey;
   } else if (!wcscmp(arg_string, L"shiftKey")) {
     event->modifiers |= WebInputEvent::ShiftKey;
   } else if (!wcscmp(arg_string, L"altKey")) {
     event->modifiers |= WebInputEvent::AltKey;
-#if defined(OS_WIN)
     event->isSystemKey = true;
-#endif
   } else if (!wcscmp(arg_string, L"metaKey")) {
     event->modifiers |= WebInputEvent::MetaKey;
   }
 }
 
 void ApplyKeyModifiers(const CppVariant* arg, WebKeyboardEvent* event) {
   if (arg->isObject()) {
     std::vector<std::wstring> args = arg->ToStringVector();
     for (std::vector<std::wstring>::const_iterator i = args.begin();
          i != args.end(); ++i) {
@@ skipping 316 matching lines @@
         needs_shift_key_modifier = NeedsShiftModifier(code);
         generate_char = true;
       }
     }
 
     // For one generated keyboard event, we need to generate a keyDown/keyUp
     // pair; refer to EventSender.cpp in WebKit/WebKitTools/DumpRenderTree/win.
     // On Windows, we might also need to generate a char event to mimic the
     // Windows event flow; on other platforms we create a merged event and test
     // the event flow that that platform provides.
-    WebKeyboardEvent event_down, event_up;
-#if defined(OS_WIN)
+    WebKeyboardEvent event_down, event_char, event_up;
     event_down.type = WebInputEvent::RawKeyDown;
-#else
-    event_down.type = WebInputEvent::KeyDown;
-#endif
     event_down.modifiers = 0;
     event_down.windowsKeyCode = code;
     if (generate_char) {
       event_down.text[0] = code;
       event_down.unmodifiedText[0] = code;
     }
     event_down.setKeyIdentifierFromWindowsKeyCode();
 
     if (args.size() >= 2 && (args[1].isObject() || args[1].isString()))
       ApplyKeyModifiers(&(args[1]), &event_down);
 
     if (needs_shift_key_modifier)
       event_down.modifiers |= WebInputEvent::ShiftKey;
 
-    event_up = event_down;
+    event_char = event_up = event_down;
     event_up.type = WebInputEvent::KeyUp;
     // EventSendingController.m forces a layout here, with at least one
     // test (fast\forms\focus-control-to-page.html) relying on this.
     webview()->layout();
 
+#if defined(OS_MACOSX)
+    // On Mac OS, some layout tests (such as "delete-by-word-001.html") sends
+    // an option-key (or alt-key) event to test it is mapped to an appropriate
+    // editor command (such as "DeleteWordBackward").
+    // On the other hand, EditorClientImpl::handleEditingKeyboardEvent()
+    // ignores the key event whose isSystemKey value is true and cannot map
+    // an editor command to an option-key event.
+    // As a workaround for this problem, we set isSystemKey of RawKeyDown
+    // events to false.
+    event_down.isSystemKey = false;

[Avi (use Gerrit), 2009/10/21 15:19:15]

I thought the system_key param on events was always false on the Mac...

+#endif
     webview()->handleInputEvent(event_down);
 
-#if defined(OS_WIN)
     if (generate_char) {
-      WebKeyboardEvent event_char = event_down;
       event_char.type = WebInputEvent::Char;
       event_char.keyIdentifier[0] = '\0';
       webview()->handleInputEvent(event_char);
     }
-#endif
 
     webview()->handleInputEvent(event_up);
   }
 }
 
 void EventSendingController::dispatchMessage(
     const CppArgumentList& args, CppVariant* result) {
   result->SetNull();
 
 #if defined(OS_WIN)
@@ skipping 183 matching lines @@
 
 void EventSendingController::fireKeyboardEventsToElement(
     const CppArgumentList& args, CppVariant* result) {
   result->SetNull();
 }
 
 void EventSendingController::clearKillRing(
     const CppArgumentList& args, CppVariant* result) {
   result->SetNull();
 }