Issue 258020: GTK: Refactor some things so GTK doesn't touch the on disk image cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 258020: GTK: Refactor some things so GTK doesn't touch the on disk image cache. (Closed)

Created:
11 years, 2 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony, Miranda Callahan

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

GTK: Refactor some things so GTK doesn't touch the on disk image cache. Hopefully will solve crash. BUG=23588 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28066

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -41 lines)			Patch
M	chrome/browser/browser_theme_provider.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_theme_provider.cc	View	3 chunks	+39 lines, -30 lines	0 comments	Download
M	chrome/browser/gtk/gtk_theme_provider.cc	View	2 chunks	+17 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

lgtm. yay, no crashing in Linux! On 2009/10/02 21:56:31, Elliot Glaysher wrote: >

11 years, 2 months ago (2009-10-02 22:13:12 UTC) #2

Elliot Glaysher

11 years, 2 months ago (2009-10-05 22:21:36 UTC) #4

After looking at this patch some more, I don't think it fixes the core issues.
The new impl function still accesses the |themed_image_cache_|. I'll have to
take a different approach.

Expand Messages | Collapse Messages