Issue 258012: [Mac] Insert views into the proper place in the view hierarchy when tearing o...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 258012: [Mac] Insert views into the proper place in the view hierarchy when tearing o... (Closed)

Created:
11 years, 2 months ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Insert views into the proper place in the view hierarchy when tearing off tabs. BUG=http://crbug.com/19320 BUG=http://crbug.com/23407 BUG=http://crbug.com/20555 TEST=Tearing off a tab with an open infobar should not show a blank transparent space. After tearing off a tab, both find in page and fullscreen should work properly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27992

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -28 lines)			Patch
M	chrome/browser/cocoa/browser_window_controller.mm	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/cocoa/tab_window_controller.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/cocoa/tab_window_controller.mm	View	1	2 chunks	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

Been running with this for a while, haven't noticed any weird drawing problems yet.

11 years, 2 months ago (2009-10-02 15:07:32 UTC) #1

pink (ping after 24hrs)

http://codereview.chromium.org/258012/diff/1/2 File chrome/browser/cocoa/tab_window_controller.mm (left): http://codereview.chromium.org/258012/diff/1/2#oldcode63 Line 63: - (NSArray*)viewsToMoveToOverlay { remove this from the header ...

11 years, 2 months ago (2009-10-02 15:20:23 UTC) #2

LGTM

Expand Messages | Collapse Messages