Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2577001: Fix double to integer conversions in runtime string indexing. (Closed)

Created:
10 years, 6 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix double to integer conversions in runtime string indexing. Committed: http://code.google.com/p/v8/source/detail?r=4791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/string-charat.js View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Repeshko
10 years, 6 months ago (2010-06-03 11:05:25 UTC) #1
Mads Ager (chromium)
10 years, 6 months ago (2010-06-03 11:21:10 UTC) #2
LGTM

Could you extend the test to cover Infinities as well?

Powered by Google App Engine
This is Rietveld 408576698