Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2576005: Update metrics_daemon to use base/time.h instead of time_t directly. (Closed)

Created:
10 years, 6 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
davidjames, David James
CC:
chromium-os-reviews_chromium.org, petkov, Luigi Semenzato, sosa
Base URL:
ssh://git@chromiumos-git/chromeos
Visibility:
Public.

Description

Update metrics_daemon to use base/time.h instead of time_t directly. Also, guard against time jumps in the active daily use metric collection. BUG=none TEST=unit tests; gmerge'd on the target device and inspected the logs.

Patch Set 1 #

Patch Set 2 : Remove unused constant. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -140 lines) Patch
M metrics_daemon.h View 7 chunks +19 lines, -13 lines 0 comments Download
M metrics_daemon.cc View 12 chunks +30 lines, -17 lines 0 comments Download
M metrics_daemon_test.cc View 8 chunks +134 lines, -110 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
petkov
10 years, 6 months ago (2010-06-03 22:47:02 UTC) #1
David James
10 years, 6 months ago (2010-06-03 23:55:16 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698