Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2576003: First phase of migration to new named property query callbacks. (Closed)

Created:
10 years, 6 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

First phase of migration to new named property query callbacks. Eventually named property query callbacks will return attributes (as an integer) or an empty handle if property is not intercepted. To gradually migrate to this new API, USE_NEW_QUERY_CALLBACK macro would control if old or new style API is used. So the migration plan is: 1) introduce new API which should be explictily enabled; 2) switch to new API defining USE_NEW_QUERY_CALLBACK before include of <v8.h> (that would require changes to client code as well) 3) remove old API from v8 4) remove #define USE_NEW_QUERY_CALLBACK from clients. Committed: http://code.google.com/p/v8/source/detail?r=4797

Patch Set 1 #

Patch Set 2 : Better version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -65 lines) Patch
M include/v8.h View 1 5 chunks +49 lines, -5 lines 0 comments Download
M src/api.cc View 1 3 chunks +15 lines, -14 lines 0 comments Download
M src/objects.cc View 1 1 chunk +12 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-decls.cc View 16 chunks +35 lines, -33 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Mads, may you have a look? The main incompatible change is omission of v8::False return ...
10 years, 6 months ago (2010-06-04 10:15:03 UTC) #1
Mads Ager (chromium)
10 years, 6 months ago (2010-06-04 11:36:15 UTC) #2
LGTM

Let's make the transition period as short as possible on this!

Powered by Google App Engine
This is Rietveld 408576698