Configure git-cl hooks based on git-cl-upload-hook.

Configure git-cl hooks based on git-cl-upload-hook.

BUG=5339
TEST=git cl config downloads and installs configured
hooks

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28748

[Evan Martin, 2009-10-06 22:31:21]

http://codereview.chromium.org/257070/diff/1/2
File codereview.settings (right):

http://codereview.chromium.org/257070/diff/1/2#newcode10
Line 10: GITCL_PREUPLOAD:
http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/git-cl-upload-h...
Hm, maybe better to not hardcode in a revision number?

I think there's some way to get the most recent one.  Maybe revision=HEAD?

[chase, 2009-10-06 22:36:35]

http://codereview.chromium.org/257070/diff/1/2
File codereview.settings (right):

http://codereview.chromium.org/257070/diff/1/2#newcode10
Line 10: GITCL_PREUPLOAD:
http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/git-cl-upload-h...
On 2009/10/06 22:31:21, Evan Martin wrote:
> Hm, maybe better to not hardcode in a revision number?
> 
> I think there's some way to get the most recent one.  Maybe revision=HEAD?

I assumed this would be managed similar to DEPS -- aka change the hook in
depot_tools, then change codereview.settings to pull the right version.  What
was your reservation against hardcoding the revision?  (I'm fine either way.)

[Evan Martin, 2009-10-06 22:41:57]

On 2009/10/06 22:36:35, chase wrote:
> http://codereview.chromium.org/257070/diff/1/2
> File codereview.settings (right):
> 
> http://codereview.chromium.org/257070/diff/1/2#newcode10
> Line 10: GITCL_PREUPLOAD:
>
http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/git-cl-upload-h...
> On 2009/10/06 22:31:21, Evan Martin wrote:
> > Hm, maybe better to not hardcode in a revision number?
> > 
> > I think there's some way to get the most recent one.  Maybe revision=HEAD?
> 
> I assumed this would be managed similar to DEPS -- aka change the hook in
> depot_tools, then change codereview.settings to pull the right version.  What
> was your reservation against hardcoding the revision?  (I'm fine either way.)

Hrm, I guess either way we're going to need people to manually rerun "git cl
config ..." to get newer versions of this stuff?  Argh, maybe this is not the
right approach.  :(

Since people always have the "correct" version of depot_tools in their local
checkout, maybe we could find that script somehow?

[chase, 2009-10-06 22:53:19]

> Hrm, I guess either way we're going to need people to manually rerun "git cl
> config ..." to get newer versions of this stuff?  Argh, maybe this is not the
> right approach.  :(

Okay.

> Since people always have the "correct" version of depot_tools in their local
> checkout, maybe we could find that script somehow?

I can whip something up that does that: The hook file would change to just
import a git_cl_hooks file (from depot_tools) and call its main method.  The
hook file itself should rarely change in that case.  And the git_cl_hooks file
would run the appropriate hook -- it would look a lot like what
git-cl-upload-hook looks like now.

WDYT?

[chase, 2009-10-06 23:44:00]

I updated to point to HEAD.  I'll have a separate CL soon for the depot_tools
side of these changes.

[chase, 2009-10-12 21:33:03]

Ping?

[Evan Martin, 2009-10-12 21:35:09]

LGTM

[imapsystem8, 2017-08-21 20:32:03]

imapsystem8@gmail.com changed reviewers:
+ imapsystem8@gmail.com

[imapsystem8, 2017-08-21 20:32:04]

481b8f8e9c401b0cea994a97273bc8f6268c8992

[imapsystem8, 2017-08-22 07:32:04]

lgtm

[imapsystem8, 2017-08-22 07:32:06]

lgtm

lgtm

[imapsystem8, 2017-08-22 07:32:08]

lgtm

lgtm

lgtm

[imapsystem8, 2017-08-22 07:32:11]

lgtm

lgtm

lgtm