Issue 257056: Resubmit http://codereview.chromium.org/243096 with gcc compile error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 257056: Resubmit http://codereview.chromium.org/243096 with gcc compile error (Closed)

Created:
11 years, 2 months ago by Erik does not do reviews

Modified:
9 years, 7 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -7 lines)			Patch
M	chrome/browser/extensions/extension_host.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View		2 chunks	+18 lines, -3 lines	0 comments	Download
M	chrome/browser/views/browser_bubble_win.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages.h	View	1	4 chunks	+10 lines, -4 lines	0 comments	Download
M	chrome/test/data/extensions/samples/set_page_color/popup.html	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

Erik does not do reviews

11 years, 2 months ago (2009-10-06 00:05:33 UTC) #1

FYI Matt.  This review is identical to the previous CL.  I just fixed a bogus
local merge I had done in render_message.h.