This is a second attempt at submitting this changelist. The original one was...

This is a second attempt at submitting this changelist. The original one was
http://codereview.chromium.org/196053 It turns out, since none of our tests
abstract time correctly, unittests are very sensitive to subtle changes in
timing. This made some of the valgrind tests on Linux fail, and unfortunately,
neither my desktop nor the trybots could reproduce the problem reliably.

As far as I can tell, all the (design) bugs are in the unittests. The browser
is actually fine.

Tweaked the code a little more. Will resubmit and carefully monitor the
buildbots.


Original change description follows:

When converting between units of time or data types of different precision, 
we have to be careful to consistently round in the same direction. 

Timeout checks usually check if Now() is less or equal to a deadline in order 
to determine if a timeout has occurred. This correctly handles the case where 
actual sleep times are equal or longer than requested sleep times. 

But if we round down when setting the sleep delay, this can result in 
unnecessary and expensive looping. Make sure, we always round up when converting 
to a format with less precision. 

BUG=none 
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28801

[Markus (顧孟勤), 2009-10-09 23:38:51]

The try bots are inconclusive, but in other than lots of random flakiness which
seems to happen even without my changelist, it looks as if things are passing
now.

I'd like to try submitting and I'll roll back if it causes problems.

[Evan Martin, 2009-10-10 01:43:50]

I don't like the magic sleeps.  Why are they needed?

http://codereview.chromium.org/257044/diff/4001/4002
File base/time.h (right):

http://codereview.chromium.org/257044/diff/4001/4002#newcode74
Line 74: int64 InMillisecondsRoundedUp() const;
Can you add a comment documenting this?  (The comment above doesn't describe
what "rounding up" means)

http://codereview.chromium.org/257044/diff/4001/4005
File net/socket/client_socket_pool_base_unittest.cc (right):

http://codereview.chromium.org/257044/diff/4001/4005#newcode152
Line 152: 2);
What does 2 mean here?

http://codereview.chromium.org/257044/diff/4001/4005#newcode402
Line 402: PlatformThread::Sleep(10);
Why is this necessary?

http://codereview.chromium.org/257044/diff/4001/4005#newcode723
Line 723: PlatformThread::Sleep(10);
Why is this necessary?

http://codereview.chromium.org/257044/diff/4001/4005#newcode979
Line 979: PlatformThread::Sleep(10);
If we're waiting just below, why do you need to sleep ehre?

http://codereview.chromium.org/257044/diff/4001/4005#newcode1835
Line 1835: PlatformThread::Sleep(10);
in general, sleeps are very fragile

[Paweł Hajdan Jr., 2009-10-10 09:03:21]

+eroman for net tests changes

http://codereview.chromium.org/257044/diff/4001/4009
File chrome/test/automation/automation_proxy_uitest.cc (right):

http://codereview.chromium.org/257044/diff/4001/4009#newcode904
Line 904: // Freezes randomly causing the entire ui test to hang
If you're disabling a test, please file a bug and add the link to the comment.