Issue 257029: Add an option to disable NaCl at compile time for platforms where it doesn't build yet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 257029: Add an option to disable NaCl at compile time for platforms where it doesn't build yet (Closed)

Created:
11 years, 2 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
gregoryd

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Add an option to disable NaCl at compile time for platforms where it doesn't build yet Just add disable_nacl=1 to gyp defines Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27873

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -2 lines)			Patch
M	build/common.gypi	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/app/chrome_dll_main.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/nacl_process_host.cc	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/plugin_service.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/renderer/render_process.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM