Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Issue 257028: Remove the RenderProcessHost from the list of renderer processes when we call... (Closed)

Created:
11 years, 2 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, ben+cc_chromium.org
Visibility:
Public.

Description

Remove the RenderProcessHost from the list of renderer processes when we call DeleteSoon, not in the destructor. Otherewise the process can be reused in the meantime. This matches what we do in ChildProcessHost. BUG=21038 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28034

Patch Set 1 #

Patch Set 2 : fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/renderer_host/render_process_host.cc View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
11 years, 2 months ago (2009-10-02 00:42:28 UTC) #1
brettw
11 years, 2 months ago (2009-10-02 18:15:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698