Modify the output of gclient update, gclient status to only print out...

Modify the output of gclient update, gclient status to only print out
messages when --verbose is specified or when something actually happens.

Also, remove --manually_grab_svn_rev, because we need this to happen all 
the time to get gclient update to shut up if we're comparing against HEAD.
It doesn't look like there are any real side effects of removing this.

An alternative change would be to wrap this behind a --quiet flag.

Note that the change to tests/trychange_unittest.py is an unrelated fix to get
all the tests to pass.

  R=maruel@chromium.org
  TEST=none
  BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28039

[Dirk Pranke, 2009-10-01 21:51:22]

Hi Marc-Antoine,

Can you take a look at this and see if it looks like a good idea? I'd like
gclient update and gclient status not to print out anything if they don't do
anything, so I've patched them accordingly.

If we think this isn't a good change to do across the board, can we maybe add
this behind a --quiet flag?

[M-A Ruel, 2009-10-02 01:23:10]

I guess we can let that in and see if we dislike it. I don't exactly why I
hard-coded verbose = True.

You change the behavior of manually_grab_svn_rev to default to True. We'll see
if it impacts or not. It adds an additional round trip on current rev != HEAD
case.

So lgtm.

http://codereview.chromium.org/257023/diff/1/4
File gclient.py (left):

http://codereview.chromium.org/257023/diff/1/4#oldcode895
Line 895: options.verbose = True
I really wonder why I did that.

http://codereview.chromium.org/257023/diff/1/2
File gclient_scm.py (right):

http://codereview.chromium.org/257023/diff/1/2#newcode375
Line 375: RunSVNAndGetFileList(options, ['update', '--revision', 'BASE'], path,
file_list)
80 cols

http://codereview.chromium.org/257023/diff/1/3
File gclient_utils.py (right):

http://codereview.chromium.org/257023/diff/1/3#newcode199
Line 199: messages_printed = False
unnecessary

http://codereview.chromium.org/257023/diff/1/3#newcode220
Line 220: if not messages_printed:
if not print_messages:

http://codereview.chromium.org/257023/diff/1/3#newcode223
Line 223: messages_printed = True
print_messages = True

[Dirk Pranke, 2009-10-05 20:44:11]

On 2009/10/02 01:23:10, Marc-Antoine Ruel wrote:
> I guess we can let that in and see if we dislike it. I don't exactly why I
> hard-coded verbose = True.
> 
> You change the behavior of manually_grab_svn_rev to default to True. We'll see
> if it impacts or not. It adds an additional round trip on current rev != HEAD
> case.
> 

To confirm: the change in gclient.py is good the way it is, right? You weren't
suggesting that I leave --manually-grab in?

-- Dirk

[M-A Ruel, 2009-10-05 20:54:51]

On 2009/10/05 20:44:11, dpranke wrote:
> On 2009/10/02 01:23:10, Marc-Antoine Ruel wrote:
> > I guess we can let that in and see if we dislike it. I don't exactly why I
> > hard-coded verbose = True.
> > 
> > You change the behavior of manually_grab_svn_rev to default to True. We'll
see
> > if it impacts or not. It adds an additional round trip on current rev !=
HEAD
> > case.
> > 
> 
> To confirm: the change in gclient.py is good the way it is, right? You weren't
> suggesting that I leave --manually-grab in?
> 
> -- Dirk

Right.