src/platform/vboot_reference/vboot_firmware/include/kernel_image_fw.h - Issue 2561001: Fix LoadKernel()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/platform/vboot_reference/vboot_firmware/include/kernel_image_fw.h

Issue 2561001: Fix LoadKernel() (Closed) Base URL: ssh://gitrw.chromium.org/chromiumos

Patch Set: Make requested changes. Rename bootloader start to bootloader address. Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/platform/vboot_reference/utility/load_kernel_test.c ('k') | src/platform/vboot_reference/vboot_firmware/include/load_kernel_fw.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/platform/vboot_reference/vboot_firmware/include/kernel_image_fw.h

diff --git a/src/platform/vboot_reference/vboot_firmware/include/kernel_image_fw.h b/src/platform/vboot_reference/vboot_firmware/include/kernel_image_fw.h

index 4cd53d2a405750b637b3f51c7cca9c9ab658736a..60b9f99d6938cf5cc6f5e12596614ff08b698a57 100644

--- a/src/platform/vboot_reference/vboot_firmware/include/kernel_image_fw.h

+++ b/src/platform/vboot_reference/vboot_firmware/include/kernel_image_fw.h

@@ -132,8 +132,9 @@ int VerifyKernelData(RSAPublicKey* kernel_sign_key,

* kernel_header_blob. image->kernel_data is set to NULL, since it's not

* part of the header and preamble data itself.

- * The signing key to use for kernel data verification is returned in

- * [kernel_sign_key], This must be free-d explicitly by the caller after use.

+ * On success, the signing key to use for kernel data verification is

+ * returned in [kernel_sign_key], This must be free-d explicitly by

+ * the caller after use. On failure, the signing key is set to NULL.

* Returns 0 on success, error code on failure.