Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 256075: Add git-cl upload hooks.... (Closed)

Created:
11 years, 2 months ago by chase
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add git-cl upload hooks. Provide git-cl upload and dcommit hooks based on this single hooks file. Installed via git-cl config. Loads and calls the PresubmitSupport library. Test failure before a dcommit halts the check-in. BUG=5339 TEST=hooks file runs presubmit checks and halts checkin (dcommit) or repeats error messages (upload). hooks file runs and doesn't interrupt process if no errors present. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28125

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
A git-cl-upload-hook View 1 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
chase
11 years, 2 months ago (2009-10-06 03:20:31 UTC) #1
M-A Ruel
lgtm
11 years, 2 months ago (2009-10-06 15:06:54 UTC) #2
Evan Martin
http://codereview.chromium.org/256075/diff/1/2 File git-cl-upload-hook (right): http://codereview.chromium.org/256075/diff/1/2#newcode36 Line 36: root = Backquote(['git', 'rev-parse', '--show-cdup']).rstrip() fwiw, you call ...
11 years, 2 months ago (2009-10-06 17:06:11 UTC) #3
chase
11 years, 2 months ago (2009-10-06 17:11:43 UTC) #4
http://codereview.chromium.org/256075/diff/1/2
File git-cl-upload-hook (right):

http://codereview.chromium.org/256075/diff/1/2#newcode36
Line 36: root = Backquote(['git', 'rev-parse', '--show-cdup']).rstrip()
On 2009/10/06 17:06:11, Evan Martin wrote:
> fwiw, you call strip() above in backquote, so you don't need all of these
> rstrips.

Done.

Powered by Google App Engine
This is Rietveld 408576698