Issue 256074: Separate ARM-v7 compilation flags from chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 256074: Separate ARM-v7 compilation flags from chromeos (Closed)

Created:
11 years, 2 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
Kenneth Waters

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Separate ARM-v7 compilation flags from chromeos Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28197

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	build/common.gypi	View		2 chunks	+5 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kenneth Waters

11 years, 2 months ago (2009-10-06 17:15:16 UTC) #2

lgtm

I'm not sure NEON is always the right choice.  But, we can add another flag for
that if/when we find a platform where VFP is faster or a platform that doesn't
have NEON (ARM's website seems to imply that NEON is an option for ARMv7-A).

http://codereview.chromium.org/256074/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/256074/diff/1/2#newcode660
Line 660: '-mfpu=neon',
Is neon always faster, or only faster on the platform we have?

Expand Messages | Collapse Messages