Explicitly activeIgnoringOtherApps from IDC_NEW{,_INCOGNITO}_WINDOW...

chrome/browser/app_controller_mac.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/app_controller_mac.h"
 
 #include "app/l10n_util_mac.h"
 #include "base/command_line.h"
 #include "base/mac_util.h"
 #include "base/message_loop.h"
@@ skipping 430 matching lines @@
         default:
           enable = menuState_->IsCommandEnabled(tag) ? YES : NO;
       }
     }
   } else if (action == @selector(terminate:)) {
     enable = YES;
   } else if (action == @selector(showPreferences:)) {
     enable = YES;
   } else if (action == @selector(orderFrontStandardAboutPanel:)) {
     enable = YES;
+  } else if (action == @selector(newWindowFromDock:)) {
+    enable = YES;
   }
   return enable;
 }
 
 // Called when the user picks a menu item when there are no key windows. Calls
 // through to the browser object to execute the command. This assumes that the
 // command is supported and doesn't check, otherwise it would have been disabled
 // in the UI in validateUserInterfaceItem:.
 - (void)commandDispatch:(id)sender {
   Profile* defaultProfile = [self defaultProfile];
@@ skipping 199 matching lines @@
         addObserver:self
            selector:@selector(aboutWindowClosed:)
                name:kUserClosedAboutNotification
              object:aboutController_.get()];
   }
   if (![[aboutController_ window] isVisible])
     [[aboutController_ window] center];
   [aboutController_ showWindow:self];
 }
 
+// Explicitly bring to the foreground when creating new windows from the dock.
+- (void)newWindowFromDock:(id)sender {
+  [NSApp activateIgnoringOtherApps:YES];
+  [self commandDispatch:sender];
+}
+
 - (NSMenu*)applicationDockMenu:(id)sender {
   NSMenu* dockMenu = [[[NSMenu alloc] initWithTitle: @""] autorelease];
   NSString* titleStr = l10n_util::GetNSStringWithFixup(IDS_NEW_WINDOW_MAC);
   scoped_nsobject<NSMenuItem> item([[NSMenuItem alloc]
                                        initWithTitle:titleStr
-                                              action:@selector(commandDispatch:)
+                                       action:@selector(newWindowFromDock:)
                                        keyEquivalent:@""]);
   [item setTarget:self];
   [item setTag:IDC_NEW_WINDOW];
   [dockMenu addItem:item];
 
   titleStr = l10n_util::GetNSStringWithFixup(IDS_NEW_INCOGNITO_WINDOW_MAC);
   item.reset([[NSMenuItem alloc] initWithTitle:titleStr
-                                        action:@selector(commandDispatch:)
+                                 action:@selector(newWindowFromDock:)
                                  keyEquivalent:@""]);
   [item setTarget:self];
   [item setTag:IDC_NEW_INCOGNITO_WINDOW];
   [dockMenu addItem:item];
 
   return dockMenu;
 }
 
 @end
 
 //---------------------------------------------------------------------------
 
 // Stub for cross-platform method that isn't called on Mac OS X.
 void ShowOptionsWindow(OptionsPage page,
                        OptionsGroup highlight_group,
                        Profile* profile) {
   NOTIMPLEMENTED();
 }