Generate IDs for --load-extension by hashing the path instead

chrome/common/extensions/extension.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 88 matching lines @@
 #if defined(OS_WIN)
   static const char* kExtensionRegistryPath;
 #endif
 
   // The number of bytes in a legal id.
   static const size_t kIdSize;
 
   // The mimetype used for extensions.
   static const char kMimeType[];
 
-  Extension()
-      : location_(INVALID), is_theme_(false),
-        background_page_ready_(false) {}
   explicit Extension(const FilePath& path);
   virtual ~Extension();
 
-  // Resets the id counter. This is only useful for unit tests.
-  static void ResetGeneratedIdCounter() {
-    id_counter_ = 0;
-  }
-
   // Checks to see if the extension has a valid ID.
   static bool IdIsValid(const std::string& id);
 
   // Returns true if the specified file is an extension.
   static bool IsExtension(const FilePath& file_name);
 
   // Whether the |location| is external or not.
   static inline bool IsExternalLocation(Location location) {
     return location == Extension::EXTERNAL_PREF ||
            location == Extension::EXTERNAL_REGISTRY;
@@ skipping 23 matching lines @@
 
   // |input| is expected to be the text of an rsa public or private key. It
   // tolerates the presence or absence of bracking header/footer like this:
   //     -----(BEGIN|END) [RSA PUBLIC/PRIVATE] KEY-----
   // and may contain newlines.
   static bool ParsePEMKeyBytes(const std::string& input, std::string* output);
 
   // Does a simple base64 encoding of |input| into |output|.
   static bool ProducePEM(const std::string& input, std::string* output);
 
-  // Note: The result is coverted to lower-case because the browser enforces
-  // hosts to be lower-case in omni-bar.
-  static bool GenerateIdFromPublicKey(const std::string& input,
-                                      std::string* output);
+  // Generates an extension ID from arbitrary input. The same input string will
+  // always generate the same output ID.
+  static bool GenerateId(const std::string& input, std::string* output);
 
   // Expects base64 encoded |input| and formats into |output| including
   // the appropriate header & footer.
   static bool FormatPEMForFileOutput(const std::string input,
       std::string* output, bool is_public);
 
   // Determine whether |new_extension| has increased privileges compared to
   // |old_extension|.
   static bool IsPrivilegeIncrease(Extension* old_extension,
                                   Extension* new_extension);
@@ skipping 97 matching lines @@
   // Runtime data:
   // Put dynamic data about the state of a running extension below.
 
   // Whether the background page, if any, is ready. We don't load other
   // components until then. If there is no background page, we consider it to
   // be ready.
   bool GetBackgroundPageReady();
   void SetBackgroundPageReady();
 
  private:
-  // Counter used to assign ids to extensions that are loaded using
-  // --load-extension.
-  static int id_counter_;
-
-  // Returns the next counter id. Intentionally post-incrementing so that first
-  // value is 0.
-  static int NextGeneratedId() { return id_counter_++; }
-
   // Helper method that loads a UserScript object from a
   // dictionary in the content_script list of the manifest.
   bool LoadUserScriptHelper(const DictionaryValue* content_script,
                             int definition_index,
                             std::string* error,
                             UserScript* result);
 
   // Helper method that loads a ExtensionAction object from a
   // dictionary in the page_action or browser_action section of the manifest.
   ExtensionAction* LoadExtensionActionHelper(
@@ skipping 102 matching lines @@
 
   // True if the background page is ready.
   bool background_page_ready_;
 
   FRIEND_TEST(ExtensionTest, LoadPageActionHelper);
 
   DISALLOW_COPY_AND_ASSIGN(Extension);
 };
 
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_H_