Generate IDs for --load-extension by hashing the path instead

chrome/browser/extensions/extension_browsertests_misc.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/ref_counted.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/extensions/extensions_service.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/renderer_host/site_instance.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #if defined(TOOLKIT_GTK)
 #include "chrome/browser/gtk/extension_shelf_gtk.h"
 #else
 #include "chrome/browser/views/extensions/extension_shelf.h"
 #endif  // defined(TOOLKIT_GTK)
 
 #include "chrome/browser/views/frame/browser_view.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension_error_reporter.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/ui_test_utils.h"
 #include "net/base/net_util.h"
 
-// ID assigned to the first unpacked extension loaded by LoadExtension().
-#define kDefaultExtensionID "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
-
 const std::wstring kSubscribePage =
     L"files/extensions/samples/subscribe_page_action/subscribe.html";
 const std::wstring kValidFeed0 = L"files/feeds/feed_script.xml";
 const std::wstring kValidFeed1 = L"files/feeds/feed1.xml";
 const std::wstring kValidFeed2 = L"files/feeds/feed2.xml";
 const std::wstring kValidFeed3 = L"files/feeds/feed3.xml";
 const std::wstring kValidFeed4 = L"files/feeds/feed4.xml";
 const std::wstring kValidFeed5 = L"files/feeds/feed5.xml";
 const std::wstring kInvalidFeed1 = L"files/feeds/feed_invalid1.xml";
 const std::wstring kInvalidFeed2 = L"files/feeds/feed_invalid2.xml";
@@ skipping 200 matching lines @@
 
   // Navigation prompts the location bar to load page actions.
   FilePath test_dir;
   PathService::Get(chrome::DIR_TEST_DATA, &test_dir);
   FilePath feed = test_dir.AppendASCII("feeds")
                           .AppendASCII("feed.html");
 
   ui_test_utils::NavigateToURL(browser(), net::FilePathToFileURL(feed));
   ASSERT_TRUE(WaitForPageActionCountChangeTo(1));
 
-  UnloadExtension(kDefaultExtensionID);
+  UnloadExtension(last_loaded_extension_id_);
 
   // Make sure the page action goes away when it's unloaded.
   ASSERT_TRUE(WaitForPageActionCountChangeTo(0));
 }
 #endif  // defined(OS_WIN) || defined(OS_LINUX)
 
 GURL GetFeedUrl(HTTPTestServer* server, const std::wstring& feed_page) {
   static GURL base_url = server->TestServerPageW(kSubscribePage);
   GURL feed_url = server->TestServerPageW(feed_page);
   return GURL(base_url.spec() + std::string("?") + feed_url.spec() +
@@ skipping 351 matching lines @@
 }
 
 // Tests that an extension page can call window.open to an extension URL and
 // the new window has extension privileges.
 IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WindowOpenExtension) {
   ASSERT_TRUE(LoadExtension(
       test_data_dir_.AppendASCII("uitest").AppendASCII("window_open")));
 
   TabContents* newtab = WindowOpenHelper(
       browser(),
-      GURL("chrome-extension://" kDefaultExtensionID "/test.html"),
+      GURL(std::string("chrome-extension://") + last_loaded_extension_id_ +
+           "/test.html"),
       "newtab.html");
 
   bool result = false;
   ui_test_utils::ExecuteJavaScriptAndExtractBool(
       newtab->render_view_host(), L"", L"testExtensionApi()", &result);
   EXPECT_TRUE(result);
 }
 
 // Tests that if an extension page calls window.open to an invalid extension
 // URL, the browser doesn't crash.
 IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WindowOpenInvalidExtension) {
   ASSERT_TRUE(LoadExtension(
       test_data_dir_.AppendASCII("uitest").AppendASCII("window_open")));
 
   WindowOpenHelper(
       browser(),
-      GURL("chrome-extension://" kDefaultExtensionID "/test.html"),
+      GURL(std::string("chrome-extension://") + last_loaded_extension_id_ +
+           "/test.html"),
       "chrome-extension://thisissurelynotavalidextensionid/newtab.html");
 
   // If we got to this point, we didn't crash, so we're good.
 }
 
 // Tests that calling window.open from the newtab page to an extension URL
 // does not give the new window extension privileges - because the opening page
 // does not have extension privileges.
 IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, WindowOpenNoPrivileges) {
   ASSERT_TRUE(LoadExtension(
       test_data_dir_.AppendASCII("uitest").AppendASCII("window_open")));
 
   TabContents* newtab = WindowOpenHelper(
       browser(),
       GURL("about:blank"),
-      "chrome-extension://" kDefaultExtensionID "/newtab.html");
+      std::string("chrome-extension://") + last_loaded_extension_id_ +
+          "/newtab.html");
 
   // Extension API should fail.
   bool result = false;
   ui_test_utils::ExecuteJavaScriptAndExtractBool(
       newtab->render_view_host(), L"", L"testExtensionApi()", &result);
   EXPECT_FALSE(result);
 }
 
 // Tests that a renderer's plugin list is properly updated when we load and
 // unload an extension that contains a plugin.
@@ skipping 38 matching lines @@
       tab->render_view_host(), L"", L"testPluginWorks()", &result);
   EXPECT_TRUE(result);
   browser()->Reload();
   ui_test_utils::WaitForNavigationInCurrentTab(browser());
 
   ui_test_utils::ExecuteJavaScriptAndExtractBool(
       tab->render_view_host(), L"", L"testPluginWorks()", &result);
   EXPECT_FALSE(result);
 }
 #endif