Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 256037: Ported Chrome's WebGL implementation to Mac OS X. Removed code which... (Closed)

Created:
11 years, 2 months ago by Ken Russell (Google)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Ported Chrome's WebGL implementation to Mac OS X. Removed code which used the GPU to vertically flip the framebuffer. Updated GLEW to use standard dlopen / dlsym rather than deprecated mach-o/dyld functions; updated README.chromium. BUG=http://crbug.com/21852 TEST=none (runs existing WebGL tests; more coming) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27902

Patch Set 1 #

Total comments: 8

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -333 lines) Patch
M third_party/glew/README.chromium View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/glew/src/glew.c View 1 chunk +4 lines, -15 lines 0 comments Download
M webkit/api/src/GraphicsContext3D.cpp View 1 2 28 chunks +339 lines, -315 lines 0 comments Download
M webkit/webkit.gyp View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
11 years, 2 months ago (2009-10-02 01:44:24 UTC) #1
darin (slow to review)
http://codereview.chromium.org/256037/diff/1/3 File webkit/api/src/GraphicsContext3D.cpp (right): http://codereview.chromium.org/256037/diff/1/3#newcode155 Line 155: #define NUM_TRACKED_POINTER_STATES 2 nit: use a const or ...
11 years, 2 months ago (2009-10-02 19:03:27 UTC) #2
Ken Russell (switch to Gerrit)
http://codereview.chromium.org/256037/diff/1/3 File webkit/api/src/GraphicsContext3D.cpp (right): http://codereview.chromium.org/256037/diff/1/3#newcode155 Line 155: #define NUM_TRACKED_POINTER_STATES 2 On 2009/10/02 19:03:27, darin wrote: ...
11 years, 2 months ago (2009-10-02 20:43:32 UTC) #3
darin (slow to review)
LGTM except: http://codereview.chromium.org/256037/diff/5001/6002 File webkit/api/src/GraphicsContext3D.cpp (right): http://codereview.chromium.org/256037/diff/5001/6002#newcode157 Line 157: kNumTrackedPointerStates = 2 webkit style names ...
11 years, 2 months ago (2009-10-02 20:46:42 UTC) #4
Ken Russell (switch to Gerrit)
http://codereview.chromium.org/256037/diff/5001/6002 File webkit/api/src/GraphicsContext3D.cpp (right): http://codereview.chromium.org/256037/diff/5001/6002#newcode157 Line 157: kNumTrackedPointerStates = 2 On 2009/10/02 20:46:42, darin wrote: ...
11 years, 2 months ago (2009-10-02 20:52:17 UTC) #5
darin (slow to review)
11 years, 2 months ago (2009-10-02 20:55:14 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698