Issue 256036: Do not use the utility process on linux....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 256036: Do not use the utility process on linux.... (Closed)

Created:
11 years, 2 months ago by asargent_no_longer_on_chrome

Modified:
9 years, 7 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, Paweł Hajdan Jr., pam+watch_chromium.org, tim (not reviewing), ben+cc_chromium.org, Miranda Callahan

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Do not use the utility process on linux. We don't currently use the zygote to spawn the utility process, so after browser updates bad bugs can occur with mismatched subprocesses. See crbug.com/23327 and crbug.com/22703. BUG=23327 TEST=Extensions installation/autoupdate and New Tab Page tip download should still work.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -8 lines)			Patch
M	chrome/browser/extensions/extension_updater.cc	View	1 2 3 4	1 chunk	+10 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/sandboxed_extension_unpacker.cc	View	1 2 3 4	1 chunk	+10 lines, -2 lines	0 comments	Download
M	chrome/browser/utility_process_host.cc	View	1 2 3 4	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/utility_process_host_unittest.cc	View	1 2 3 4	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/web_resource/web_resource_service.cc	View	1 2 3 4	2 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

11 years, 2 months ago (2009-10-02 18:12:26 UTC) #2

lgtm

http://codereview.chromium.org/256036/diff/1007/18
File chrome/browser/web_resource/web_resource_service.cc (left):

http://codereview.chromium.org/256036/diff/1007/18#oldcode290
Line 290: 
I think you need the newline here

Expand Messages | Collapse Messages