Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: chrome/browser/extensions/file_reader.h

Issue 256022: Loads local resources from current locale subtree if available, if not it fal... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extensions_ui.cc ('k') | chrome/browser/extensions/file_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/file_reader.h
===================================================================
--- chrome/browser/extensions/file_reader.h (revision 28157)
+++ chrome/browser/extensions/file_reader.h (working copy)
@@ -1,27 +1,28 @@
// Copyright (c) 2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-//
-// This file defines an interface for reading a file asynchronously on a
-// background thread.
-#ifndef CHROME_BROWSER_NET_FILE_READER_H_
-#define CHROME_BROWSER_NET_FILE_READER_H_
+#ifndef CHROME_BROWSER_EXTENSIONS_FILE_READER_H_
+#define CHROME_BROWSER_EXTENSIONS_FILE_READER_H_
#include <string>
-#include "base/file_path.h"
#include "base/ref_counted.h"
#include "base/task.h"
+#include "chrome/common/extensions/extension_resource.h"
class MessageLoop;
+// This file defines an interface for reading a file asynchronously on a
+// background thread.
+// Consider abstracting out a FilePathProvider (ExtensionResource) and moving
+// back to chrome/browser/net if other subsystems want to use it.
class FileReader : public base::RefCountedThreadSafe<FileReader> {
public:
// Reports success or failure and the data of the file upon success.
typedef Callback2<bool, const std::string&>::Type Callback;
- FileReader(const FilePath& path, Callback* callback);
+ FileReader(const ExtensionResource& resource, Callback* callback);
// Called to start reading the file on a background thread. Upon completion,
// the callback will be notified of the results.
@@ -31,9 +32,9 @@
void ReadFileOnBackgroundThread();
void RunCallback(bool success, const std::string& data);
- FilePath path_;
+ ExtensionResource resource_;
Callback* callback_;
MessageLoop* origin_loop_;
};
-#endif // CHROME_BROWSER_NET_FILE_READER_H_
+#endif // CHROME_BROWSER_EXTENSIONS_FILE_READER_H_
« no previous file with comments | « chrome/browser/extensions/extensions_ui.cc ('k') | chrome/browser/extensions/file_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698