SocketStreamHandle implementation (skelton) for chromium

SocketStreamHandle implementation (skelton) for chromium.

BUG=12497
TEST=none

[ukai, 2009-09-30 11:05:02]

I'd like to land it before a patch of webkit bug 29917 is landed.

[Yuzo, 2009-09-30 11:30:07]

http://codereview.chromium.org/256010/diff/1/2
File webkit/api/src/SocketStreamHandle.cpp (right):

http://codereview.chromium.org/256010/diff/1/2#newcode57
Line 57: private:
Indent?

http://codereview.chromium.org/256010/diff/1/2#newcode122
Line 122: #endif
Add
// ENABLE(WEB_SOCKETS)
?

[ukai, 2009-09-30 11:34:14]

http://codereview.chromium.org/256010/diff/1/2
File webkit/api/src/SocketStreamHandle.cpp (right):

http://codereview.chromium.org/256010/diff/1/2#newcode57
Line 57: private:
On 2009/09/30 11:30:08, Yuzo wrote:
> Indent?

Done.

http://codereview.chromium.org/256010/diff/1/2#newcode122
Line 122: #endif
On 2009/09/30 11:30:08, Yuzo wrote:
> Add
> // ENABLE(WEB_SOCKETS)
> ?
> 

Done.

[darin (slow to review), 2009-09-30 17:04:28]

http://codereview.chromium.org/256010/diff/1003/1004
File webkit/api/src/SocketStreamHandle.cpp (right):

http://codereview.chromium.org/256010/diff/1003/1004#newcode73
Line 73: // ---------------- SocketStreamHandle
nit: the convention for these comments is "// Foo -------" with the dashes
expanded out to 80 chars.

http://codereview.chromium.org/256010/diff/1003/1004#newcode85
Line 85: setClient(NULL);
nit: webkit style is to use "0" instead of NULL

[ukai, 2009-10-01 01:48:44]

http://codereview.chromium.org/256010/diff/1003/1004
File webkit/api/src/SocketStreamHandle.cpp (right):

http://codereview.chromium.org/256010/diff/1003/1004#newcode73
Line 73: // ---------------- SocketStreamHandle
On 2009/09/30 17:04:28, darin wrote:
> nit: the convention for these comments is "// Foo -------" with the dashes
> expanded out to 80 chars.

Done.

http://codereview.chromium.org/256010/diff/1003/1004#newcode85
Line 85: setClient(NULL);
On 2009/09/30 17:04:28, darin wrote:
> nit: webkit style is to use "0" instead of NULL

Done.

[Yuzo, 2009-10-01 02:08:58]

LGTM.

http://codereview.chromium.org/256010/diff/1006/1007
File webkit/api/src/SocketStreamHandle.cpp (right):

http://codereview.chromium.org/256010/diff/1006/1007#newcode49
Line 49: static PassOwnPtr<SocketStreamHandleInternal> create(
The argument should be on the same line, while '{' be on its own.

http://codereview.chromium.org/256010/diff/1006/1007#newcode64
Line 64: SocketStreamHandle *handle)
Ditto.

http://codereview.chromium.org/256010/diff/1006/1007#newcode75
Line 75: SocketStreamHandle::SocketStreamHandle(
const KURL& ... should be on the same line.

[ukai, 2009-10-01 02:25:10]

http://codereview.chromium.org/256010/diff/1006/1007
File webkit/api/src/SocketStreamHandle.cpp (right):

http://codereview.chromium.org/256010/diff/1006/1007#newcode49
Line 49: static PassOwnPtr<SocketStreamHandleInternal> create(
On 2009/10/01 02:08:58, Yuzo wrote:
> The argument should be on the same line, while '{' be on its own.
> 

Done.

http://codereview.chromium.org/256010/diff/1006/1007#newcode64
Line 64: SocketStreamHandle *handle)
On 2009/10/01 02:08:58, Yuzo wrote:
> Ditto.

Done.

http://codereview.chromium.org/256010/diff/1006/1007#newcode75
Line 75: SocketStreamHandle::SocketStreamHandle(
On 2009/10/01 02:08:58, Yuzo wrote:
> const KURL& ... should be on the same line.

Done.

[tyoshino (SeeGerritForStatus), 2009-10-01 03:36:13]

LGTM

http://codereview.chromium.org/256010/diff/7001/6002
File webkit/api/src/SocketStreamHandle.cpp (right):

http://codereview.chromium.org/256010/diff/7001/6002#newcode31
Line 31: #include "config.h"
nit: Please move #include "SocketStreamHandle.h" here to be consistent with the
format of other files in this dir.
(StorageNamespaceProxy.cpp, WebNotification.cpp,
MediaPlayerPrivateChromium.cpp, ApplicationCacheHost.cpp, etc)

[ukai, 2009-10-01 04:32:29]

http://codereview.chromium.org/256010/diff/7001/6002
File webkit/api/src/SocketStreamHandle.cpp (right):

http://codereview.chromium.org/256010/diff/7001/6002#newcode31
Line 31: #include "config.h"
On 2009/10/01 03:36:13, tyoshino wrote:
> nit: Please move #include "SocketStreamHandle.h" here to be consistent with
the
> format of other files in this dir.
> (StorageNamespaceProxy.cpp, WebNotification.cpp,
> MediaPlayerPrivateChromium.cpp, ApplicationCacheHost.cpp, etc)
> 

Done.